Guys, Going through the firmware code and it looks like the code is using ; as a remark. Surely we should be following the C convention of // or /* and */. ; is a line terminator in C and PL/SQL regards Stephen Here is the code in question in process_string //newlines are ends of commands. if (c != '\n') { // Start of comment - ignore any bytes received from now on if (c == ';') comment = true; // If we're not in comment mode, add it to our array. if (!comment) cmdbuffer[serial_count++] = c; } https://reprap.org/forum/read.php?12,29397,29397#msg-29397 Wed, 22 Jul 2026 04:11:14 -0400 Phorum 5.2.23 https://reprap.org/forum/read.php?12,29397,29458#msg-29458 https://reprap.org/forum/read.php?12,29397,29458#msg-29458
Wow I though g codes was a reprap invention. Thanks for the heads up

Stephen]]> stephen george RepRap Host Sun, 01 Nov 2009 16:55:11 -0500 https://reprap.org/forum/read.php?12,29397,29433#msg-29433 https://reprap.org/forum/read.php?12,29397,29433#msg-29433 emt RepRap Host Sun, 01 Nov 2009 04:39:50 -0500 https://reprap.org/forum/read.php?12,29397,29422#msg-29422 https://reprap.org/forum/read.php?12,29397,29422#msg-29422
> That refers to a comment in the G code string from the host/ terminal. The code tells the parser to ignore it.

Yep I see that but shouldn't that be

G01 X500. F100 // This line moves X 500mm at 100mm a minute

Rather than

G01 X500. F100 ; This line moves X 500mm at 100mm a minute

Stephen]]> stephen george RepRap Host Sat, 31 Oct 2009 20:40:35 -0400 https://reprap.org/forum/read.php?12,29397,29402#msg-29402 https://reprap.org/forum/read.php?12,29397,29402#msg-29402

G01 X500. F100 ; This line moves X 500mm at 100mm a minute]]> emt RepRap Host Sat, 31 Oct 2009 04:31:12 -0400 https://reprap.org/forum/read.php?12,29397,29397#msg-29397 https://reprap.org/forum/read.php?12,29397,29397#msg-29397
Going through the firmware code and it looks like the code is using ; as a remark.
Surely we should be following the C convention of // or /* and */.

; is a line terminator in C and PL/SQL

regards

Stephen


Here is the code in question in process_string


//newlines are ends of commands.
if (c != '\n')
{
// Start of comment - ignore any bytes received from now on
if (c == ';')
comment = true;

// If we're not in comment mode, add it to our array.
if (!comment)
cmdbuffer[serial_count++] = c;
}]]> stephen george RepRap Host Sat, 31 Oct 2009 01:56:56 -0400