Proposed improvement: change homing offsets to milimeters

Re: Proposed improvement: change homing offsets to milimeters

TTN — Fri, 04 Dec 2015 13:40:58 -0500

Quote
repetier
.. so units should not really matter.

Yep. Well, until someone like me changes the microstepping rate and gets a head into bed crash (:P)

Re: Proposed improvement: change homing offsets to milimeters

repetier — Fri, 04 Dec 2015 07:47:59 -0500

We need these values in steps as that is the unit we internally work for this correction. These get set by firmware with G132 S2 command during bed calibration so units should not really matter.

Proposed improvement: change homing offsets to milimeters

TTN — Thu, 03 Dec 2015 21:28:16 -0500

Improvement suggestion:

Change:

#define DELTA_X_ENDSTOP_OFFSET_STEPS 0
#define DELTA_Y_ENDSTOP_OFFSET_STEPS 0
#define DELTA_Z_ENDSTOP_OFFSET_STEPS 0

to:

#define DELTA_X_ENDSTOP_OFFSET_STEPS 0.0*AXIS_STEPS_PER_MM
#define DELTA_Y_ENDSTOP_OFFSET_STEPS 0.0*AXIS_STEPS_PER_MM
#define DELTA_Z_ENDSTOP_OFFSET_STEPS 0.0*AXIS_STEPS_PER_MM

unless, of course, floats are an issue.

I'm not too familiar with the C syntax, but I'm assuming we will have to convert the number to an int before using it later in the code.

I can go ahead and open a git pull request, but thought it better to discuss first.