Welcome! Log In Create A New Profile

Advanced

Upload to the board failed after LCD enabled

Posted by williamstark 
Upload to the board failed after LCD enabled
August 10, 2019 05:47AM
Hi Folks,

I recently brought BigTreeTech SKR V1.3 and uncommented REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER and clicked upload button but faced
an error that say

Marlin\src\lcd\ultralcd.cpp:767:9: error: 'touch_buttons' was not declared in this scope
if (touch_buttons) {
^~~~~~~~~~~~~
Marlin\src\lcd\ultralcd.cpp:767:9: note: suggested alternative: 'buttons'
if (touch_buttons) {

^~~~~~~~~~~~~
buttons
Marlin\src\lcd\ultralcd.cpp:805:5: error: 'else' without a previous 'if'
else wait_for_unclick = false;
^~~~
*** [.pio\build\LPC1768\src\src\lcd\ultralcd.cpp.o] Error 1

I am not sure what above mean but can anyone shed light to why I am recieving these errors?
Attachments:
open | download - Configuration.h (80.5 KB)
Re: Upload to the board failed after LCD enabled
August 10, 2019 07:10AM
Its a bug in latest marlin... reported here [github.com]

Someone has presumed that touch is active in this part of the code without checking it has been enabled
Re: Upload to the board failed after LCD enabled
August 10, 2019 07:48AM
A hack to get it to work is

edit Marlin\src\lcd\ultralcd.cpp:

at line 767 you will find
if (touch_buttons) {

insert the following above that line
#if ENABLED(TOUCH_BUTTONS)

so it becomes
#if ENABLED(TOUCH_BUTTONS)
     if (touch_buttons) {



at line 793 you will find
else {

add this line after it
#endif


at line 806 you will find the line
}


change it to
#if ENABLED(TOUCH_BUTTONS)
    }
  #endif
Re: Upload to the board failed after LCD enabled
August 10, 2019 09:00PM
Sorry I did not followed your suggestion correctly so now its works, the upload passed but nothing show up on the display.

The board is connect to the computer with REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER connected. Any suggestion to why it not showing up?

Edited 2 time(s). Last edit at 08/10/2019 09:10PM by williamstark.
Attachments:
open | download - ultralcd.cpp (47.9 KB)
Re: Upload to the board failed after LCD enabled
August 11, 2019 02:09AM
An official fix has been posted. Grab the new ultralcd.cpp from [github.com]
Re: Upload to the board failed after LCD enabled
August 11, 2019 04:06AM
Thank you for the update DUST, the display controller is not showing anything, what could that be? I looked in U8glib-HAL and don't see REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER supported?
Sorry, only registered users may post in this forum.

Click here to login