TMC2208/TMC2130 short circuit protection is disabled by default

I was wondering what the reason is for the TMC2208 driver used in Marlin to have short circuit protection disabled for both the low side and high side MOSFETS's ?

I've enabled the short circuit protection with so far no ill effects by adding the following into the TMC driver section in Configuration_ADV.h file (we use UART comms from MCU to each TMC2208) ..

  // enable low-side and high-side short circuit to ground output mosfet protection
  #define TMC_ADV() { \
		stepperX.diss2g(false);  stepperX.diss2vs(false);  \
		stepperY.diss2g(false);  stepperY.diss2vs(false);  \
		stepperZ.diss2g(false);  stepperZ.diss2vs(false); \
		stepperZ2.diss2g(false); stepperZ2.diss2vs(false); \
 	}

The reason we want the protection is because we already blew a TMC2208 driver chip when testing them (an exposed stepper motor wire accidently touched 0V).

The protection is no doubt disabled for the TMC2130's as well, but not looked at the TMC2130 driver code so can't yet confirm that.

Edited 3 time(s). Last edit at 03/13/2019 12:38PM by Pippy.

Strange indeed, if that's true. RepRapFirmware enables short circuit protection on TMC2208/2224, TMC2660, TMC5130 and TMC 5160/5161 drivers by default.

Edited 1 time(s). Last edit at 03/13/2019 01:58PM by dc42.

---

Large delta printer [miscsolutions.wordpress.com], E3D tool changer, Robotdigg SCARA printer, Crane Quad and Ormerod

Disclosure: I design Duet electronics and work on RepRapFirmware, [duet3d.com].

Well, I wouldn't mind a duet 2 wifi with the reprap firmware !

When we're done with this horrible mks rubbish (hardware/soldering faults are many with brand new controller & driver boards) and marlin we will get a duet for sure.

In the mean time, we'll battle our way through the sub-low end .. not by choice I should add - at this present time.