Marlin 1.1.9 fails to compile with new IDE 1.8.6

I've had 1.1.9 compiling OK for a while and saw that IDE Arduino 1.8.6 was available for download from [www.arduino.cc]. Thought I'd give it a try and was rewarded but a long list of errors similar to those shown below. Roll back to 1.8.5 and all is well again. Anyone else try it yet?:


Errors with 1.8.6

In file included from C:\Users\Dave\AppData\Local\Temp\arduino_build_700613\sketch\HAL.h:33:0,

from C:\Users\Dave\AppData\Local\Temp\arduino_build_700613\sketch\MarlinConfig.h:39,

from C:\Users\Dave\AppData\Local\Temp\arduino_build_700613\sketch\Sd2Card.cpp:29:

Sd2Card.h:100:39: error: pasting "/* SPI Master In Slave Out pin*/" and "_DDR" does not give a valid preprocessing token

#define SPI_MISO_PIN MISO_PIN // SPI Master In Slave Out pin

^

C:\Users\Dave\AppData\Local\Temp\arduino_build_700613\sketch\fastio.h:86:42: note: in definition of macro '_SET_INPUT'

#define _SET_INPUT(IO) CBI(DIO ## IO ## _DDR, DIO ## IO ## _PIN)

^

C:\Users\Dave\AppData\Local\Temp\arduino_build_700613\sketch\Sd2Card.cpp:316:3: note: in expansion of macro 'SET_INPUT'

SET_INPUT(SPI_MISO_PIN);

^

C:\Users\Dave\AppData\Local\Temp\arduino_build_700613\sketch\Sd2Card.cpp:316:13: note: in expansion of macro 'SPI_MISO_PIN'

SET_INPUT(SPI_MISO_PIN);

^

Sd2Card.h:100:39: error: pasting "/* SPI Master In Slave Out pin*/" and "_PIN" does not give a valid preprocessing token

#define SPI_MISO_PIN MISO_PIN // SPI Master In Slave Out pin

I do not have Marlin 1.1.9

Though I tried to Compile my Marlin 1.1.7 and Marlin 1.1.8 and received similar messages, Must be something we are overlooking.

Compiles Marlin 1.1.6 and Marlin 1.1.5

Sd2Card.h:100:39: error: pasting "/* SPI Master In Slave Out pin*/" and "_DDR" does not give a valid preprocessing token

#define SPI_MISO_PIN MISO_PIN // SPI Master In Slave Out pin

^

sketch\fastio.h:94:35: note: in definition of macro '_SET_INPUT'

#define _SET_INPUT(IO) do {DIO ## IO ## _DDR &= ~_BV(DIO ## IO ## _PIN); } while (0)

^

sketch\Sd2Card.cpp:316:3: note: in expansion of macro 'SET_INPUT'

SET_INPUT(SPI_MISO_PIN);

Edited 1 time(s). Last edit at 08/26/2018 04:41PM by Roberts_Clif.

---

Computer Programmer / Electronics Technician

Interesting

Latest marlin (pulled moments ago) and IDE 1.8.6 64bit on ubuntu compiles fine

only issue was getting arduino ide 1.8.6 to run in the first instance.
I needed to comment out assistive_technologies=org.GNOME.Accessibility.AtkWrapper from /etc/java11-openjdk/accessibility.properties or it gives the error

java.awt.AWTError: Assistive Technology not found

did you update your boards and libraries in their respective managers?

Edited 1 time(s). Last edit at 08/27/2018 12:08AM by Dust.

I posted the same issue over in the Arduino forum and got this response from "pert" one of the major members. It seems we are not alone and it's not us. It seems the end of line comments are bothering the compiler.
And by Dusts comment I guess we can assume that this problem is for the Windows version.

I think this bug will be tracked at:
[github.com]
I originally mistook this for a previously reported issue but after more investigation it appears I was wrong. See my comment here for details:
[github.com]

setting #define MOTHERBOARD BOARD_ULTIMAKER and I get the same error on linux also

but not with default #define MOTHERBOARD BOARD_RAMPS_14_EFB