Marlin 1.1.9 Full Reprap Graphic not showing correctly

I'm trying to port over my settings from 1.1.8 to 1.1.9 for my JGAurora Z603s.

I've got everything working apart from a glitchy LCD. I've compared source code for about 3 hours but not getting anywhere at all.

Attached is a screenshot so you can see. It's sort of displaying correctly but not! Any ideas what setting I need to change?

Thanks,

Steve

It actually look like you are trying to send LCD data to the wrong type LCD and the data is wrapping around the diaplay.

Can you post a Google Drive link to both Configuration.h files so we can see what could be causing the problem.

---

Computer Programmer / Electronics Technician

Hi,

Thanks for the reply.

Sure, here is a google drive link to both config files
[drive.google.com]

Also in config adv.. I've noticed some additional code. If I uncomment the define LIGHTWEIGHT_UI it then displays a different main screen, but this is displayed correctly. When you then click the wheel it goes into the menu screens but these are not displayed right.

#if ENABLED(U8GLIB_ST7920)
    /**
     * ST7920-based LCDs can emulate a 16 x 4 character display using
     * the ST7920 character-generator for very fast screen updates.
     * Enable LIGHTWEIGHT_UI to use this special display mode.
     *
     * Since LIGHTWEIGHT_UI has limited space, the position and status
     * message occupy the same line. Set STATUS_EXPIRE_SECONDS to the
     * length of time to display the status message before clearing.
     *
     * Set STATUS_EXPIRE_SECONDS to zero to never clear the status.
     * This will prevent position updates from being displayed.
     */
    //#define LIGHTWEIGHT_UI
    #if ENABLED(LIGHTWEIGHT_UI)
      #define STATUS_EXPIRE_SECONDS 20
    #endif
  #endif

#endif // DOGLCD

Quite a few bits of code have changed, I've been struggling on where to look.

Thanks,

Steve

You have changed Display Character Set from JAPANESE to WESTERN

You may need to change this line
#define DISPLAY_CHARSET_HD44780 JAPANESE


I also noted these other lines have been changed
#define DEFAULT_MAX_FEEDRATE { 300, 300, 80, 25 } // Changed from 40 to 80

#define X_PROBE_OFFSET_FROM_EXTRUDER 10 // Changed from 32 to 10]
#define Y_PROBE_OFFSET_FROM_EXTRUDER 10 // Changed from 0 to 10
#define Z_PROBE_OFFSET_FROM_EXTRUDER 0 // Changed from -1 to 0

#define Z_PROBE_SPEED_SLOW (Z_PROBE_SPEED_FAST / 2)
#define Z_CLEARANCE_DEPLOY_PROBE 10 // Z Clearance for Deploy/Stow
//#define Z_HOMING_HEIGHT 4
//#define G26_MESH_VALIDATION
#define GRID_MAX_POINTS_X 3
#define HOMING_FEEDRATE_Z (4*60)


Used WinMerge to do comparisons

Edited 1 time(s). Last edit at 08/19/2018 07:24AM by Roberts_Clif.

---

Computer Programmer / Electronics Technician

Yep, I've tried both Jap and west.. no difference. The probe bit wont effect the lcd, plus I've removed the probe now anyway and commented it out. Its got to be a bug they have introduced when altering the code. Spent another few hours trying to trace it but no luck. :-(

OK! I Understand. Still the display appears to be wrapping the text as if it is looking for less characters per line.
The spacing for X 0 and Y 0 seem ok though the spacing for Z 0 is incorrect, Could be that your.....................

I see it your " JG Aurora Z603S " name is too long shorten it to Just " JG Aurora " or " JGAurora Z603 "
The Period behind "Ready." is on the top line throwing all the other lines off.

#define CUSTOM_MACHINE_NAME "JG Aurora"

Edited 6 time(s). Last edit at 08/19/2018 11:57AM by Roberts_Clif.

---

Computer Programmer / Electronics Technician

Hi,

Nope tried that and it's still the same. Plus, that name works fine on 1.1.8. I've done a quick video and uploaded it so you can see..


[www.youtube.com]

Thanks,

I can see it has something to do with the Display Graphics.

Does this apply
[github.com]

---

Computer Programmer / Electronics Technician

Thanks for the link, I've posted in GitHub to see if they have any ideas I could try.

Thanks again,

Steve

Solved it.

It was a timing issue. Well, I never solved it but I found the answer on GitHub.

In the config.h file, added the 3 below lines and it's working well.


#define REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER
#define ST7920_DELAY_1 DELAY_NS(0)
#define ST7920_DELAY_2 DELAY_NS(250)
#define ST7920_DELAY_3 DELAY_NS(250)

Posted here to help others.

Steve

I found this but no explanation!

#define REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER

#ifndef ST7920_DELAY_1
#define ST7920_DELAY_1 DELAY_NS(125)
#endif

#ifndef ST7920_DELAY_2
#define ST7920_DELAY_2 DELAY_NS(125)
#endif

#ifndef ST7920_DELAY_3
#define ST7920_DELAY_3 DELAY_NS(125)
#endif

Could someone point me to where so I can learn about it.

Thank You.

OK! DELAY_NS() does not measure in NOPs (as done previously). Delays are in nanoseconds.

Edited 1 time(s). Last edit at 08/20/2018 03:42PM by Roberts_Clif.

---

Computer Programmer / Electronics Technician

have got the same issu
on old arduino ide works fine
on eclipse and arduino 1.8.10 - issue
it looks like compiler optimisation issue ,used different u8glib - no changes.
...
fix
#define REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER
#define ST7920_DELAY_1 DELAY_NS(0)
#define ST7920_DELAY_2 DELAY_NS(250)
#define ST7920_DELAY_3 DELAY_NS(250)

helps
thank you